RFR: 8358694: VM asserts if CodeCacheSegmentSize is not a power of 2 [v6]

[Damon Fenacci]

On Mon, 16 Jun 2025 08:49:16 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:

>> Makes sure that JVM exits gracefully when `CodeCacheSegmentSize` is not a power of 2.
>
> Amit Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   updates testcase

Thanks for changing the test @offamitkumar.

test/hotspot/jtreg/compiler/codecache/CodeCacheSegmentSizeTest.java line 2:

> 1: /*
> 2:  * Copyright (c) 2024 IBM Corporation. All rights reserved.

Suggestion:

 * Copyright (c) 2025 IBM Corporation. All rights reserved.

test/hotspot/jtreg/compiler/codecache/CodeCacheSegmentSizeTest.java line 74:

> 72:         OutputAnalyzer output = new OutputAnalyzer(pb.start());
> 73: 
> 74:         output.shouldContain("openjdk version"); // typical first line

The test fails here for me (the output has the string "java version", not "openjdk version").
Maybe instead of checking this string we could check that there is no error?

-------------

PR Review: https://git.openjdk.org/jdk/pull/25708#pullrequestreview-2931604110
PR Review Comment: https://git.openjdk.org/jdk/pull/25708#discussion_r2149650252
PR Review Comment: https://git.openjdk.org/jdk/pull/25708#discussion_r2149649320