RFR: 8306706: Support out-of-line code generation for MachNodes [v5]

[Srinivas Vamsi Parasa]

On Tue, 23 May 2023 16:12:27 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:

>> Hi,
>> 
>> This patch adds supports for MachNodes to emit an out-of-line piece of code in the stub section of the compiled method. This allows the separation of the uncommon path from the common one, which speeds up the common path a little bit and increases compiled code density. Please take a look and leave reviews.
>> 
>> Thanks a lot.
>
> Quan Anh Mai has updated the pull request incrementally with one additional commit since the last revision:
> 
>   comments describe C2GeneralStub

src/hotspot/cpu/x86/c2_MacroAssembler_x86.cpp line 4339:

> 4337:   }
> 4338: 
> 4339:   auto stub = C2CodeStub::make<Register, XMMRegister, address>(dst, src, slowpath_target, 23, convertF2I_slowpath);

Hi @merykitty, could you please explain how the size 23 was computed? This value does not work with APX and I created a PR (https://github.com/openjdk/jdk/pull/25787) for that.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13602#discussion_r2150975884