RFR: 8359801: RISC-V: Simplify Interpreter::profile_taken_branch
Anjian Wen
wenanjian at openjdk.org
Wed Jun 18 06:45:29 UTC 2025
On Wed, 18 Jun 2025 02:03:43 GMT, SendaoYan <syan at openjdk.org> wrote:
>> Do the same thing as [JDK-8357434](https://bugs.openjdk.org/browse/JDK-8357434) [JDK-8358655](https://bugs.openjdk.org/browse/JDK-8358655) but for riscv
>>
>> The Interpreter::profile_taken_branch has the same sbbptr pattern with [JDK-8358105](https://bugs.openjdk.org/browse/JDK-8358105),The counter is 64-bit, never practically overflows , and no other code cares about it. so we can remove the overflows check
>
> src/hotspot/cpu/riscv/interp_masm_riscv.cpp line 1077:
>
>> 1075: test_method_data_pointer(mdp, profile_continue);
>> 1076:
>> 1077: // We are not taking a branch. Increment the not taken count.
>
> Seems an extra whitespace before `Increment`
Thanks for review, it seems that there are same whitespace at x86 and aarch64, and there are about 29 whitespaces with 'Increment' after in dir 'src/hotspot/cpu/' , so I'm not sure whether it is a kind of format.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25848#discussion_r2153771406
More information about the hotspot-compiler-dev
mailing list