RFR: 8356708: C2: loop strip mining expansion doesn't take sunk stores into account [v4]

[Emanuel Peter]

On Tue, 17 Jun 2025 12:49:14 GMT, Roland Westrelin <roland at openjdk.org> wrote:

>> src/hotspot/share/opto/loopnode.cpp line 3007:
>> 
>>> 3005: #endif
>>> 3006: 
>>> 3007:   // Sunk stores are reachable from the memory state of the outer loop safepoint
>> 
>> Is it true that the control of the safepoint is the `cle_exit_proj`? Could we add an assert for that? So we are just looking for all memory between those two control nodes? Or is it more complicated?
>
> Yes, it is. I added a call to `verify_strip_mined()` that checks the shape of the outer loop including the control flow nodes.

Great, thanks :)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25717#discussion_r2153830113