RFR: 8020282: Generated code quality: redundant LEAs in the chained dereferences [v4]

[Manuel Hässig]

On Tue, 17 Jun 2025 17:46:59 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

>>> > Is this scenario exercised by any of the new tests? If not, would it be possible to construct an additional test where we verify that the peephole is not applied in this case?
>>> 
>>> It is not. I was only able to find such a case once with all VM intrinsics disabled some time ago, but was not able to reproduce one since. I'll have another try to find one.
>> 
>> OK, that would be great! If you do not find one, I think the PR is still OK because it is easy to see how the peephole would handle the scenario. But it would be of course better to confirm it with an actual test case.
>
>> @robcasloz, I integrated all your suggestions and simplified the IR-tests.
> 
> Thanks!
> 
>> But I was unfortunately not able to create a test that reliably safepoints.
> 
> Fair enough, thanks for trying.

Thank you for your thorough reviews @robcasloz and @vnkozlov!
I addressed all remaining comments.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/25471#issuecomment-2983370308