RFR: 8347901: C2 should remove unused leaf / pure runtime calls
Emanuel Peter
epeter at openjdk.org
Wed Jun 18 14:51:39 UTC 2025
On Wed, 18 Jun 2025 11:36:55 GMT, Emanuel Peter <epeter at openjdk.org> wrote:
>> src/hotspot/share/opto/callnode.cpp line 1309:
>>
>>> 1307: return proj_out_or_null(TypeFunc::Parms) == nullptr;
>>> 1308: }
>>> 1309: // We make a tuple of the global input state + TOP for the output values.
>>
>> Suggestion:
>>
>> }
>>
>> // We make a tuple of the global input state + TOP for the output values.
>>
>> Nit: there should be a newline between the methods.
>
> Also: the comment says exactly what the method name says ... I'd suggest deleting the comment or writing something with additional information.
For example: why do you put TOP for the return values?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25760#discussion_r2154376599
More information about the hotspot-compiler-dev
mailing list