RFR: 8359270: C2: alignment check should consider base offset when emitting arraycopy runtime call [v3]

[Fei Yang]

On Thu, 19 Jun 2025 10:42:57 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Fei Yang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>> 
>>  - improve test
>>  - Merge remote-tracking branch 'upstream/master' into JDK-8359270
>>  - add test
>>  - Merge remote-tracking branch 'upstream/master' into JDK-8359270
>>  - 8359270: C2: alignment check should consider base offset when emitting arraycopy runtime call
>
> test/hotspot/jtreg/compiler/c2/irTests/stringopts/TestArrayCopySelect.java line 50:
> 
>> 48:     public static void main(String[] args) {
>> 49:         TestFramework.runWithFlags("-XX:+UseCompactObjectHeaders", "-XX:-CompactStrings", "-XX:MaxInlineSize=70", "-XX:MinInlineFrequencyRatio=0");
>> 50:         TestFramework.runWithFlags("-XX:-UseCompactObjectHeaders", "-XX:-CompactStrings", "-XX:MaxInlineSize=70", "-XX:MinInlineFrequencyRatio=0");
> 
> Wouldn't it make more sense to simply enforce inlining via a compile command?

Yes, that would be more explict about inlining. I updated the test accordingly. Still test good on these platforms.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25765#discussion_r2156781132