RFR: 8316694: Implement relocation of nmethod within CodeCache [v28]

Chad Rakoczy duke at openjdk.org
Thu Jun 19 22:09:37 UTC 2025


On Wed, 18 Jun 2025 00:52:08 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Chad Rakoczy has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use new _metadata_size instead of _jvmci_data_size
>
> src/hotspot/share/code/relocInfo.cpp line 415:
> 
>> 413: // We must check that the new offset can still fit in the instruction
>> 414: // for architectures that have small branch ranges
>> 415: #if defined(AARCH64) || defined(RISV)
> 
> Should be `RISCV64` instead of `RISV`.

This was removed in favor of `NativeCall::set_destination_mt_safe`

> src/hotspot/share/code/relocInfo.cpp line 419:
> 
>> 417:     if (NativeCall::is_call_at(addr())) {
>> 418:       NativeCall* call = nativeCall_at(addr());
>> 419:       address trampoline = call->get_trampoline();
> 
> We don't have this `call->get_trampoline()` method for RISC-V now. Trampoline call for RISC-V was deprecated by https://bugs.openjdk.org/browse/JDK-8332689 and later removed by https://bugs.openjdk.org/browse/JDK-8343430.
> So I guess RISC-V is not affected here in this case? CC: @robehn

Same as above. This was removed in favor of `NativeCall::set_destination_mt_safe`

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23573#discussion_r2157708178
PR Review Comment: https://git.openjdk.org/jdk/pull/23573#discussion_r2157708522


More information about the hotspot-compiler-dev mailing list