RFR: 8360131: Remove use of soon-to-be-removed APIs by CTW framework

[David Beaumont]

On Fri, 20 Jun 2025 15:45:18 GMT, Chen Liang <liach at openjdk.org> wrote:

>> Migrate the CWT framework to use only supported JRT file system access for fetching class bytes.
>> This avoids accessing APIs in ImageReader which are scheduled to be removed as part of preview mode class support in Valhalla (essentially these APIs are "too low level" and expose semantics that are incompatible with supporting preview classes in Valhalla).
>> 
>> This will be a further change to this code when the preview mode work goes in, but this will be limited to how the file system is opened (with or without preview mode).
>
> test/hotspot/jtreg/testlibrary/ctw/src/sun/hotspot/tools/ctw/ClassPathJimageEntry.java line 82:
> 
>> 80:     }
>> 81: 
>> 82:     //private final ImageReader reader;
> 
> Suggestion:

*doh* - thanks.

> test/hotspot/jtreg/testlibrary/ctw/src/sun/hotspot/tools/ctw/ClassPathJimageEntry.java line 114:
> 
>> 112:             }
>> 113:         } catch (IOException e) {
>> 114:             throw new RuntimeException(e);
> 
> Maybe throw an error for consistency with other methods in this class?

Personally I don't like `Error` as a response to runtime issues like this, but consistency is probably good, so done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25916#discussion_r2159291998
PR Review Comment: https://git.openjdk.org/jdk/pull/25916#discussion_r2159293103