RFR: 8359120: Improve warning message when fail to load hsdis library [v2]
Taizo Kurashige
tkurashige at openjdk.org
Mon Jun 23 12:04:29 UTC 2025
On Thu, 19 Jun 2025 09:10:53 GMT, Manuel Hässig <mhaessig at openjdk.org> wrote:
> I don't think we should use [MachCode]
You're right. I will stop using `[MachCode]`.
> Here are a few suggestions I would personally prefer:
Thank you for your suggestion.
I prefer the former expression.
However, if hsdis is loaded successfully, the disassembled code will appear in `[Disassembly]` instead of `[MachCode]`, so I don't think "unable to show disassembled code in MachCode section" is appropriate.
Do you think "undisassembled" is clunky? "undisassembled" is also used in [src/hotspot/share/code/nmethod.cpp#L3428](https://github.com/openjdk/jdk/blob/c220b1358c91bce2eb7515e9f600004c7b975ee6/src/hotspot/share/code/nmethod.cpp#L3428), so I don't think it's too clunky.
So, for example, how about `Loading hsdis library failed, undisassembled code is shown in MachCode section`? If "undisassembled" is clunky, I think it could be "not disassembled" for example.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25726#discussion_r2161451247
More information about the hotspot-compiler-dev
mailing list