RFR: 8325467: Support methods with many arguments in C2 [v17]
Daniel Lundén
dlunden at openjdk.org
Mon Jun 23 14:00:26 UTC 2025
On Fri, 20 Jun 2025 10:23:57 GMT, Emanuel Peter <epeter at openjdk.org> wrote:
>> This is a bit tricky. It is indeed a pointer type (`uintptr_t`), but it is not used as a pointer. It is used to store the register mask bits. So I guess this is then not an implicit null check? It is an implicit zero check :slightly_smiling_face:
>
>> Do not use ints or pointers as (implicit) booleans with &&, ||, if, while. Instead, compare explicitly, i.e. if (x != 0) or if (ptr != nullptr), etc.
>
> Ok, well no matter what, it would not conform to the style. Maybe you already fixed it though, not sure.
Ah, good to know. I fixed all the occurrences I could find (and some bonus ones). I guess there is no static checker available to automate this?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20404#discussion_r2161704150
More information about the hotspot-compiler-dev
mailing list