RFR: 8348868: AArch64: Add backend support for SelectFromTwoVector [v4]
Andrew Haley
aph at openjdk.org
Wed Jun 25 09:58:31 UTC 2025
On Wed, 25 Jun 2025 06:07:31 GMT, Xiaohong Gong <xgong at openjdk.org> wrote:
>> Bhavana Kilambi has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Addressed review comments
>
> src/hotspot/cpu/aarch64/aarch64_vector.ad line 255:
>
>> 253: // the default VectorRearrange + VectorBlend is generated as the performance of the default
>> 254: // implementation was slightly better/similar than the implementaion for SelectFromTwoVector.
>> 255: // As the SVE2 "tbl" instruction in unpredicated and partial operations cannot be generated
>
> `in` -> `is`
"as" -> "because".
Consider the difference between "as I was walking home, the Perseid meteor shower produced a spectacular display" and "because I was walking home, the Perseid meteor shower produced a spectacular display".
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23570#discussion_r2166307149
More information about the hotspot-compiler-dev
mailing list