RFR: 8360641: TestCompilerCounts fails after 8354727 [v2]
Manuel Hässig
mhaessig at openjdk.org
Mon Jun 30 08:40:56 UTC 2025
On Fri, 27 Jun 2025 19:42:49 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:
>> Manuel Hässig has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Make it work for product and address review comments
>
> test/hotspot/jtreg/compiler/arguments/TestCompilerCounts.java line 30:
>
>> 28: * @requires vm.flagless
>> 29: * @requires vm.bits == "64"
>> 30: * @requires vm.debug
>
> Why you limited it to debug VM?
Originally, I put this restriction there because `-XX:CodeCacheMinimumUseSpace` is a debug flag. But your comment prompted me to check if that flag has an ergonomic, which it does not. Hence, I made the test work for both debug and product in ab1c7d9.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26024#discussion_r2174534585
More information about the hotspot-compiler-dev
mailing list