RFR: 8360641: TestCompilerCounts fails after 8354727 [v2]
Manuel Hässig
mhaessig at openjdk.org
Mon Jun 30 08:40:56 UTC 2025
On Mon, 30 Jun 2025 06:41:00 GMT, Damon Fenacci <dfenacci at openjdk.org> wrote:
>> Manuel Hässig has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Make it work for product and address review comments
>
> test/hotspot/jtreg/compiler/arguments/TestCompilerCounts.java line 138:
>
>> 136: // Non-tiered modes
>> 137: int c1OnlyCount = heuristicCount(cpus, Compilation.C1Only);
>> 138: pass(c1OnlyCount, opt, "-XX:TieredStopAtLevel=1", "-XX:NonNMethodCodeHeapSize="+NonNMethodCodeHeapSize, "-XX:CodeCacheMinimumUseSpace="+CodeCacheMinimumUseSpace);
>
> Very minor style thing: maybe we can put whitespaces around the `+` signs.
Fixed in ab1c7d9
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26024#discussion_r2174530732
More information about the hotspot-compiler-dev
mailing list