RFR: 8350177: C2 SuperWord: Integer.numberOfLeadingZeros, numberOfTrailingZeros, reverse and bitCount have input types wrongly turncated for byte and short [v7]
Jasmine Karthikeyan
jkarthikeyan at openjdk.org
Mon Jun 30 12:47:02 UTC 2025
On Mon, 30 Jun 2025 05:53:53 GMT, Emanuel Peter <epeter at openjdk.org> wrote:
>> Jasmine Karthikeyan has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Add case for bytes and prevent vector ops from truncating
>
> src/hotspot/share/opto/superword.cpp line 2612:
>
>> 2610: case Op_XorReductionV:
>> 2611: case Op_MaxReductionV:
>> 2612: case Op_MinReductionV:
>
> Can we now remove those, since you are already handling all vectors explicitly above?
I couldn't move it earlier since reduction nodes return a regular type instead of a vector type, but I've pushed a commit that moves it to an `isa_Reduction()` check.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25440#discussion_r2174986411
More information about the hotspot-compiler-dev
mailing list