RFR: 8325478: Restructure the macro expansion compiler phase to not include macro elimination [v7]

Daniel Lundén dlunden at openjdk.org
Mon Jun 30 16:46:41 UTC 2025


On Mon, 30 Jun 2025 16:15:18 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Saranya Natarajan has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
>> 
>>   merge with master
>>   Merge branch 'master' of https://git.openjdk.org/jdk into JDK-8325478
>
> src/utils/IdealGraphVisualizer/README.md line 36:
> 
>> 34: * `N=3`: additionally, after every minor phase
>> 35: * `N=4`: additionally, after every loop optimization
>> 36: * `N=5`: additionally, after every effective IGVN, macro elimination, and expansion step (slow)
> 
> Typo `,` before `, and`.

@sarannat: I also think you should write this out in full: `... macro elimination, and macro expansion step (slow)`. The `,` before `and` in itself is not incorrect, but a question of style (see [Oxford comma](https://en.wikipedia.org/wiki/Serial_comma)).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25682#discussion_r2175500831


More information about the hotspot-compiler-dev mailing list