RFR: 8350893: Use generated names for hand generated opto runtime blobs [v2]

[Andrew Dinn]

On Thu, 27 Feb 2025 20:02:13 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Andrew Dinn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   correct error in arm stub name
>
> Hm. It looks like in release builds all of these would be "runtime stub"? Is that expected?
> 
> 
> const char* OptoRuntime::stub_name(address entry) {
> #ifndef PRODUCT
>   CodeBlob* cb = CodeCache::find_blob(entry);
>   RuntimeStub* rs =(RuntimeStub *)cb;
>   assert(rs != nullptr && rs->is_runtime_stub(), "not a runtime stub");
>   return rs->name();
> #else
>   // Fast implementation for product mode (maybe it should be inlined too)
>   return "runtime stub";
> #endif
> }

@shipilev
> Hm. It looks like in release builds all of these would be "runtime stub"? Is that expected?

git blame indicates that it's been like that since jdk7 was initially loaded in 2007-12-01 ;-)

We could perhaps fix it to say something more useful. Maybe in a separate PR in case something depends on it having that value in release builds?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/23829#issuecomment-2693858294