RFR: 8333393: PhaseCFG::insert_anti_dependences can fail to raise LCAs and to add necessary anti-dependence edges [v5]

Emanuel Peter epeter at openjdk.org
Mon Mar 3 12:12:57 UTC 2025


On Mon, 3 Mar 2025 11:42:24 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Daniel Lundén has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update after Christian's review
>
> src/hotspot/share/opto/cfgnode.cpp line 2061:
> 
>> 2059: // non-termination. For more details, see comments at the call site in
>> 2060: // PhiNode::Ideal. This is really a const method, but Node_List currently only
>> 2061: // permits non-const elements.
> 
> Which `Node_List` is this about? Would `GrowabelArray` be a good alternative?

Probably not important enough.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23691#discussion_r1977393124


More information about the hotspot-compiler-dev mailing list