RFR: 8333393: PhaseCFG::insert_anti_dependences can fail to raise LCAs and to add necessary anti-dependence edges [v5]

[Daniel Lundén]

On Mon, 3 Mar 2025 12:01:03 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> src/hotspot/share/opto/cfgnode.cpp line 2061:
>> 
>>> 2059: // non-termination. For more details, see comments at the call site in
>>> 2060: // PhiNode::Ideal. This is really a const method, but Node_List currently only
>>> 2061: // permits non-const elements.
>> 
>> Which `Node_List` is this about? Would `GrowabelArray` be a good alternative?
>
> Probably not important enough.

Thanks, I agree `GrowableArray` is a better option (now changed). It annoyed me that I couldn't make the function const due to `Node_List`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23691#discussion_r1977484031