RFR: 8315066: Add unsigned bounds and known bits to TypeInt/Long [v44]
Quan Anh Mai
qamai at openjdk.org
Mon Mar 3 15:58:01 UTC 2025
On Wed, 26 Feb 2025 11:09:31 GMT, Emanuel Peter <epeter at openjdk.org> wrote:
>> Quan Anh Mai has updated the pull request incrementally with one additional commit since the last revision:
>>
>> refine comments
>
> src/hotspot/share/opto/rangeinference.cpp line 187:
>
>> 185: bits at x > j have lower significance, and are thus irrelevant
>> 186:
>> 187: Which leads to r < lo, which contradicts that r >= lo
>
> Suggestion:
>
> Which leads to r < lo, which contradicts that r >= lo (according to definition of r)
>
> It could be nice to define it more explicitly, and give the definition of `r` a title / name.
We can say according to 2.1 here, done that!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17508#discussion_r1977761618
More information about the hotspot-compiler-dev
mailing list