RFR: 8350893: Use generated names for hand generated opto runtime blobs [v2]

[Aleksey Shipilev]

On Mon, 3 Mar 2025 10:11:38 GMT, Andrew Dinn <adinn at openjdk.org> wrote:

>> The two special case opto runtime blobs that support uncommon trap and exception handling are currently being generated using hard wired blob names determined by port-specific code. They should employ the standard blob names generated from shared declarations in file stubDeclarations.hpp.
>
> Andrew Dinn has updated the pull request incrementally with one additional commit since the last revision:
> 
>   correct error in arm stub name

> > Hm. It looks like in release builds all of these would be "runtime stub"? Is that expected?
> We could perhaps fix it to say something more useful. Maybe in a separate PR in case something depends on it having that value in release builds?

I am confused that we have `OptoRuntime::stub_id(...)`, and then we also have newly added by you:


runtime.hpp:

  // Returns the name associated with a given stub id
  static const char* stub_name(OptoStubId id) {
    assert(id > OptoStubId::NO_STUBID && id < OptoStubId::NUM_STUBIDS, "stub id out of range");
    return _stub_names[(int)id];
  }


Maybe `OptoRuntime::stub_name` should be calling that one directly, instead of going all the way through `CodeCache::find_blob`? Then we don't need any debug-defines there.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/23829#issuecomment-2695217875