Integrated: 8350095: RISC-V: Refactor string_compare

[Hamlin Li]

On Fri, 14 Feb 2025 14:32:07 GMT, Hamlin Li <mli at openjdk.org> wrote:

> Hi,
> Can you help to review this patch?
> 
> Currently, `string_compare` code is a bit complicated, main reasons include:
> 1. it has 2 piece of code respectively for LU and UL case, this is not necessary, basically LU and UL behaviour quite similar.
> 2. it mixed LL/UU and LU/UL case together, better to separate them, as they are quite different from each other.
> 
> This is not good for code reading and maintaining.
> 
> 
> So, this patch does following refactoring:
> 1. merge LU and UL code into one, i.e. remove UL code.
> 2. seperate the code into 2 methods:  LL/UU and LU/UL.
> 3. some other misc improvement.
> 
> I could do the following refactoring in another following pr, as in this pr I'm just moving code and removing code, it's easier to do it and review it. In particular the first one, as it needs to rewrite the existing code for UL/LU case.
> 1. move alignment code of `generate_compare_long_string_different_encoding` upwards to `string_compare_long_LU`.
> 2. make `SHORT_STRING` case simpler.
> 
> 
> 
> Thanks

This pull request has now been integrated.

Changeset: e470f474
Author:    Hamlin Li <mli at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/e470f474ee2176eecc211ec8e99cccc941104c68
Stats:     363 lines in 4 files changed: 193 ins; 156 del; 14 mod

8350095: RISC-V: Refactor string_compare

Reviewed-by: fyang

-------------

PR: https://git.openjdk.org/jdk/pull/23633