RFR: 8350756: C2 SuperWord Multiversioning: remove useless slow loop when the fast loop disappears [v5]

[Emanuel Peter]

On Tue, 4 Mar 2025 09:58:27 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> It would be equivalent now, since nobody inherits from `BoolNode`. But if someone ever inherits from it, then this condition would be weaker. Also: I just copied the condition.
>> 
>> I can do it if you still want me to do it, I'm on the fence with this one ;)
>
> I'm not sure if we were ever to extend `BoolNode`. And if so, I think implementing this requires to check all the `is_Bool()` conditions in our code base anyways - which I expect we have quite a lot of them. And it could be that a subclass would also allow to apply a cmove transformation. So, given that it's unlikely, I would be more inclined to change it to `is_Bool()`. But it's your call. I'm fine with both :-)

I changed it :)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23865#discussion_r1979494875