RFR: 8349582: APX NDD code generation for OpenJDK [v3]

[Sandhya Viswanathan]

On Wed, 5 Mar 2025 18:08:08 GMT, Srinivas Vamsi Parasa <sparasa at openjdk.org> wrote:

>> The goal of this PR is to generate code using APX NDD instructions.
>
> Srinivas Vamsi Parasa has updated the pull request incrementally with one additional commit since the last revision:
> 
>   remove epopcount, elzcnt, etzcnt

src/hotspot/cpu/x86/x86_64.ad line 5796:

> 5794: %}
> 5795: 
> 5796: 

A nit pick, unnecessary extra blank lines :).

src/hotspot/cpu/x86/x86_64.ad line 6239:

> 6237: 
> 6238: 
> 6239: instruct cmovI_regUCF2_ne(cmpOpUCF2 cop, rFlagsRegUCF cr, rRegI dst, rRegI src) %{

The cmovI_regUCF2_ne, cmovl_regUCF2_eq, cmovP_regUCF2_ne, cmovP_regUCF2_eq, cmovL_regUCF2_ne, cmovL_regUCF2_eq instructs could also use the ecmovl() instructions.

src/hotspot/cpu/x86/x86_64.ad line 6871:

> 6869:   predicate(UseAPX);
> 6870:   match(Set dst (AddI src1 src2));
> 6871:   effect(KILL cr);

We should also bring in the corresponding flag(PD::...); line from instruct addI_rReg in this and other rules where applicable.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23501#discussion_r1981936770
PR Review Comment: https://git.openjdk.org/jdk/pull/23501#discussion_r1981945068
PR Review Comment: https://git.openjdk.org/jdk/pull/23501#discussion_r1982059646