RFR: 8350982: -server|-client causes fatal exception on static JDK [v2]

[Ioi Lam]

On Thu, 6 Mar 2025 06:04:58 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Jiangli Zhou has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Remove '-server' from all following tests.
>>    
>>    Add @requires vm.flavor == "server" & !vm.emulatedClient since these tests run on c2:
>>    - compiler/c2/TestReduceAllocationAndHeapDump.java
>>    - compiler/inlining/InlineBimorphicVirtualCallAfterMorphismChanged.java
>>    
>>    These tests already have @requires vm.compiler2.enabled:
>>    - compiler/c2/TestReduceAllocationAndLoadKlass.java
>>    - compiler/c2/TestReduceAllocationAndNonExactAllocate.java
>>    - compiler/c2/TestReduceAllocationAndNullableLoads.java
>>    - compiler/c2/TestReduceAllocationAndPointerComparisons.java
>>    - compiler/escapeAnalysis/TestIterativeEA.java
>>    
>>    Can run on c1/c2:
>>    - compiler/escapeAnalysis/TestReduceAllocationAndNonReduciblePhi.java
>>    
>>    Already have @requires vm.flavor == "server":
>>    - compiler/intrinsics/math/TestMinMaxIntrinsics.java
>>    - compiler/profiling/TestTypeProfiling.java
>>    - gc/stress/gcbasher/TestGCBasherWithG1.java
>>    - gc/stress/gcbasher/TestGCBasherWithParallel.java
>>    - gc/stress/gcbasher/TestGCBasherWithSerial.java
>>    
>>    Not compiler specific:
>>    - runtime/CDSCompressedKPtrs/XShareAuto.java
>>  - Revert src/hotspot/share/runtime/arguments.cpp.
>
> test/hotspot/jtreg/runtime/CDSCompressedKPtrs/XShareAuto.java line 43:
> 
>> 41:     public static void main(String[] args) throws Exception {
>> 42:         ProcessBuilder pb = ProcessTools.createLimitedTestJavaProcessBuilder(
>> 43:             "-XX:+UnlockDiagnosticVMOptions",
> 
> This test was created specifically as a regression test because `-server` didn't work. I'm not sure it serves any purpose now. @iklam?

I think the test still serves as a functional test: if an archive is specified, then -Xshare:auto is used by default.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23881#discussion_r1982800754