RFR: 8350563: C2 compilation fails because PhaseCCP does not reach a fixpoint [v2]

[Liam Miller-Cushon]

On Thu, 6 Mar 2025 09:02:50 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Liam Miller-Cushon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
>> 
>>  - copyright
>>  - style
>>  - Merge branch 'openjdk:master' into mernst/JDK-8350563
>>  - RegTest
>>  - Merge branch 'openjdk:master' into mernst/JDK-8350563
>>  - push `con->(cast*)->and` uses
>
> src/hotspot/share/opto/phaseX.cpp line 2022:
> 
>> 2020:     }
>> 2021:   };
>> 2022:   to_push->visit_uses(push_and_uses_to_worklist, is_boundary);
> 
> And why not just call this line in two places, rather than having to work with `to_push`? Would that not be less code?

Matthias reports:

That was purely a stylistic choice - the two cases can be integrated, we can push from "use" in both cases. Updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23871#discussion_r1983652245