RFR: 8351348: x86_64: remove redundant supports_float16 check
Vladimir Kozlov
kvn at openjdk.org
Thu Mar 6 18:32:01 UTC 2025
On Thu, 6 Mar 2025 13:18:07 GMT, Hamlin Li <mli at openjdk.org> wrote:
> Hi,
> Can you help to review this simple patch?
> `supports_float16()` is invoked in `is_intrinsic_available -> is_intrinsic_supported`, so there is no need to call it explicitly.
>
> Thanks
I am on fence for this. You can consider it as "short-cut" to quickly check availability of feature. It will be called 2 times without it (I am not sure calls will be inlined and optimized).
-------------
PR Review: https://git.openjdk.org/jdk/pull/23932#pullrequestreview-2665306856
More information about the hotspot-compiler-dev
mailing list