RFR: 8351345: Test: Print out non-whitelisted JTreg VM or Javaoptions flag

[Christian Hagedorn]

On Thu, 6 Mar 2025 12:16:57 GMT, Hamlin Li <mli at openjdk.org> wrote:

> Hi,
> Can you help to review this trivial patch?
> Currently, it only reports that some flag is non-whitelisted, but does not print out the flag explicitly, but it's helpful to do so.
> 
> Thanks!

test/hotspot/jtreg/compiler/lib/ir_framework/TestFramework.java line 752:

> 750:             if (!flag.startsWith("-D") && !flag.startsWith("-e") && JTREG_WHITELIST_FLAGS.stream().noneMatch(flag::contains)) {
> 751:                 // Found VM flag that is not whitelisted
> 752:                 System.out.println("Non-whitelisted JTreg VM or Javaoptions flag: " + flag);

That's a good idea! Is the intention to just report the first non-whitelisted flag found or all of them? I guess just one of them is fine to indicate the reason for not performing IR matching (could be verbose to report all non-whitelisted flags otherwise). 

I would merge this message with the already existing one here and remove that one in favor of the new one:
https://github.com/openjdk/jdk/blob/a23fb0af65f491ef655ba114fcc8032a09a55213/test/hotspot/jtreg/compiler/lib/ir_framework/TestFramework.java#L612-L615

Another thought while cleaning this up: We could also improve this message
https://github.com/openjdk/jdk/blob/a23fb0af65f491ef655ba114fcc8032a09a55213/test/hotspot/jtreg/compiler/lib/ir_framework/TestFramework.java#L597-L602
and split it into three separate bailouts + messages. Could be part of this RFE (you could then set a new title for the issue to something like `[IR Framework] Improve reported disabled IR verification messages`).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23931#discussion_r1984095845