RFR: 8347459: C2: missing transformation for chain of shifts/multiplications by constants [v6]

Marc Chevalier duke at openjdk.org
Fri Mar 7 13:11:39 UTC 2025


> This collapses double shift lefts by constants in a single constant: (x << con1) << con2 => x << (con1 + con2). Care must be taken in the case con1 + con2 is bigger than the number of bits in the integer type. In this case, we must simplify to 0.
> 
> Moreover, the simplification logic of the sign extension trick had to be improved. For instance, we use `(x << 16) >> 16` to convert a 32 bits into a 16 bits integer, with sign extension. When storing this into a 16-bit field, this can be simplified into simple `x`. But in the case where `x` is itself a left-shift expression, say `y << 3`, this PR makes the IR looks like `(y << 19) >> 16` instead of the old `((y << 3) << 16) >> 16`. The former logic didn't handle the case where the left and the right shift have different magnitude. In this PR, I generalize this simplification to cases where the left shift has a larger magnitude than the right shift. This improvement was needed not to miss vectorization opportunities: without the simplification, we have a left shift and a right shift instead of a single left shift, which confuses the type inference.
> 
> This also works for multiplications by powers of 2 since they are already translated into shifts.
> 
> Thanks,
> Marc

Marc Chevalier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 16 additional commits since the last revision:

 - use a random number in testing
 - Merge branch 'master' into fix/missing-transformation-for-chain-of-shifts-multiplications-by-constants
 - + comment on why not zerocon
 - comment
 - Fix style in the few lines I haven't touched yet
 - Remove useless local, with especially helpful name
 - rename
 - Add test suggested by @dean-long exhibiting the difference between (x << 30) << 3 and x << 33
 - improve simplification of double shifts in stores
 - actually return a new node
 - ... and 6 more: https://git.openjdk.org/jdk/compare/7b1cfa3b...8e93a12f

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/23728/files
  - new: https://git.openjdk.org/jdk/pull/23728/files/b8c3d74f..8e93a12f

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=23728&range=05
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=23728&range=04-05

  Stats: 37758 lines in 1023 files changed: 17356 ins; 15313 del; 5089 mod
  Patch: https://git.openjdk.org/jdk/pull/23728.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/23728/head:pull/23728

PR: https://git.openjdk.org/jdk/pull/23728


More information about the hotspot-compiler-dev mailing list