RFR: 8350194: Last 2 parameters of ReturnNode::ReturnNode are swapped in the declaration
Tobias Hartmann
thartmann at openjdk.org
Fri Mar 7 17:57:05 UTC 2025
On Thu, 6 Mar 2025 07:42:14 GMT, Manuel Hässig <duke at openjdk.org> wrote:
> The last two parameters in the declaration of ReturnNode::ReturnNode, `frameptr` and `retadr` were swapped in the declaration compared to the definition. This commit makes the declaration consistent with the definition and the two usages in [`GraphKit::gen_stub()`](https://github.com/openjdk/jdk/blob/5c552a9d64c8116161cb9ef4c777e75a2602a75b/src/hotspot/share/opto/generateOptoStub.cpp#L267) and [`Compile::return_values()`](https://github.com/openjdk/jdk/blob/5c552a9d64c8116161cb9ef4c777e75a2602a75b/src/hotspot/share/opto/parse1.cpp#L879).
>
> Tests: tiers 1 through 3 passed.
That looks good and trivial to me. Congratulations on your first PR Manuel! :partying_face:
-------------
Marked as reviewed by thartmann (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/23927#pullrequestreview-2663601283
More information about the hotspot-compiler-dev
mailing list