RFR: 8351345: [IR Framework] Improve reported disabled IR verification messages [v2]

[Christian Hagedorn]

On Fri, 7 Mar 2025 10:53:45 GMT, Hamlin Li <mli at openjdk.org> wrote:

>> Hi,
>> Can you help to review this trivial patch?
>> Currently, it only reports that some flag is non-whitelisted, but does not print out the flag explicitly, but it's helpful to do so.
>> 
>> Thanks!
>
> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
> 
>   refine

test/hotspot/jtreg/compiler/lib/ir_framework/TestFramework.java line 602:

> 600:         boolean debugTest, irTest, nonWhiteListedTest;
> 601: 
> 602:         debugTest = Platform.isDebugBuild() && !Platform.isInt() && !Platform.isComp();

I suggest to split this up into three separate checks which generate three separate messages.

test/hotspot/jtreg/compiler/lib/ir_framework/TestFramework.java line 615:

> 613:         System.out.println("IR verification disabled due to:");
> 614:         if (!debugTest) {
> 615:             System.out.println("\tnot running a debug build (required for PrintIdeal and PrintOptoAssembly), " +

I like the improvements so far. But I think we should not use tabs since the size could be specific to the machine we are running on. I suggest to use `-` instead which could use the following structure:

IR verification disabled due to the following reason(s):
- Reason 1
- Reason 2
...
- Using non-whitelisted JTreg VM or Javaoptions flag(s):
  - Non-whitelisted flag 1
  - Non-whitelisted flag 2
  - ...

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23931#discussion_r1986765726
PR Review Comment: https://git.openjdk.org/jdk/pull/23931#discussion_r1986769438