RFR: 8351414: C2: MergeStores must happen after RangeCheck smearing [v2]
Emanuel Peter
epeter at openjdk.org
Mon Mar 10 15:00:50 UTC 2025
On Mon, 10 Mar 2025 13:44:14 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:
>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>>
>> For Christian, add comment
>
> src/hotspot/share/opto/compile.cpp line 1904:
>
>> 1902: // StoreI [ StoreL ] StoreI
>> 1903: // But now it would have been better to do this instead:
>> 1904: // [ StoreL ] [ StoreL ]
>
> Maybe you also can add a note here that RC smearing is not limited to just this one IGVN phase but that it's done in all subsequent IGVN phases (since we don't unset `_merge_stores_phase`).
I added a comment below :)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23944#discussion_r1987471099
More information about the hotspot-compiler-dev
mailing list