RFR: 8350835: C2 SuperWord: assert/wrong result when using Float.float16ToFloat with byte instead of short input [v2]

[Sandhya Viswanathan]

On Fri, 7 Mar 2025 07:51:24 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> Sandhya Viswanathan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review comments
>
> test/hotspot/jtreg/compiler/vectorization/TestFloat16ToFloatConv.java line 89:
> 
>> 87:     }
>> 88: 
>> 89:     @Test
> 
> ``` suggestion
>     /*
>      * C2 handles this in two steps: l2i handling creates ConvL2I IR ,followed by i2s conversion which onstrains the
>      * value range of the integral argument; thus, the argument fed to ConvHF2F is of type T_INT. Fix for
>      * JDK-8350835 skip over vectorizing such a case for now.
>      */
>     @Test
>     @IR(failOn = { IRNode.VECTOR_CAST_HF2F }, applyIfCPUFeatureOr = { "avx512vl", "true", "f16c", "true" })

Thanks, added the generic failOn tests for byte, int, and long test cases as it is applicable across architectures.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23939#discussion_r1988052085