RFR: 8347459: C2: missing transformation for chain of shifts/multiplications by constants [v9]

Marc Chevalier duke at openjdk.org
Tue Mar 11 10:09:38 UTC 2025


On Mon, 10 Mar 2025 15:40:34 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> src/hotspot/share/opto/memnode.cpp line 3579:
>> 
>>> 3577: // The non-rejected bits are the 8 lower one of (v << conIL - conIR).
>>> 3578: // The bits 6 and 7 of v have been thrown away after the shift left.
>>> 3579: // The simplification is still fine.
>> 
>> Suggestion for everywhere: `fine` -> `valid`.
>
> Or correct.

I like correct.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23728#discussion_r1988874742


More information about the hotspot-compiler-dev mailing list