RFR: 8330469: C2: Remove or change "PrintOpto && VerifyLoopOptimizations" as printing code condition [v2]

Roberto Castañeda Lozano rcastanedalo at openjdk.org
Tue Mar 11 14:15:06 UTC 2025


On Tue, 11 Mar 2025 11:10:10 GMT, Saranya Natarajan <duke at openjdk.org> wrote:

>> **Issue:** There are currently 9 occurrences where we guard printing code with PrintOpto && VerifyLoopOptimizations. This flag combo is never really used in practice. 
>> 
>> **Solution**: I analysed the 9 occurrence. In cases, where the flag `PrintOpto && VerifyLoopOptimizations` was followed by flag `TraceLoopOpts` with `else if` or  `|| operator` I removed the former flag. In other cases, where `PrintOpto && VerifyLoopOptimizations` was the only flag, I was replaced with `TraceLoopOpts`. 
>> 
>> **Test Result**: Link to [GitHub Action](https://github.com/sarannat/jdk/actions/runs/13723071055) run on commit [91ecc51](https://github.com/sarannat/jdk/commit/91ecc5190ce31da94bded4de210136f337286e69)
>
> Saranya Natarajan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   JDK-8330469: Addressing review comments by removing TraceLoopOpts and some dump()

Looks good to me, thanks for simplifying this code!

-------------

Marked as reviewed by rcastanedalo (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/23959#pullrequestreview-2674715849


More information about the hotspot-compiler-dev mailing list