RFR: 8350835: C2 SuperWord: assert/wrong result when using Float.float16ToFloat with byte instead of short input [v2]

[Jatin Bhateja]

On Fri, 7 Mar 2025 07:50:13 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> Sandhya Viswanathan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review comments
>
> test/hotspot/jtreg/compiler/vectorization/TestFloat16ToFloatConv.java line 80:
> 
>> 78:     }
>> 79: 
>> 80:     @Test
> 
> Suggestion:
> 
>     /*
>      *  C2 handles i2s conversion by constraining the value range of the integral argument; thus
>      *  argument fed to ConvHF2F is of type T_INT. Fix for JDK-8350835 skips over vectorizing such a case
>      *  for now.
>      */
>      @Test
>      @IR(failOn = { IRNode.VECTOR_CAST_HF2F }, applyIfCPUFeatureOr = { "avx512vl", "true", "f16c", "true" })

I don't see any harm in including the above suggested comment as you mentioned we plan to support these auto vrctoriizations in future

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23939#discussion_r1990493712