RFR: 8350896: Integer/Long.compress gets wrong type from CompressBitsNode::Value

[Emanuel Peter]

On Wed, 12 Mar 2025 08:02:52 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> src/hotspot/share/opto/intrinsicnode.cpp line 265:
>> 
>>> 263:   if (!mask_type->is_con()) {
>>> 264:     if ( opc == Op_CompressBits) {
>>> 265:       int mask_max_bw;
>> 
>> Suggestion:
>> 
>>       // Pattern: Integer/Long.compress(src_type, mask_type)
>>       int mask_max_bw;
>
> Can you also say what the meaning of `mask_max_bw` is? Possibly a more expressive name would help here too.

If I'm right here, you want to say how many many of the low significance bits are unknown, and that the rest, the high significance bits are all zero, right?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23947#discussion_r1990908641