Integrated: 8350194: Last 2 parameters of ReturnNode::ReturnNode are swapped in the declaration

Manuel Hässig duke at openjdk.org
Wed Mar 12 08:47:02 UTC 2025


On Thu, 6 Mar 2025 07:42:14 GMT, Manuel Hässig <duke at openjdk.org> wrote:

> The last two parameters in the declaration of ReturnNode::ReturnNode, `frameptr` and `retadr` were swapped in the declaration compared to the definition. This commit makes the declaration consistent with the definition and the two usages in [`GraphKit::gen_stub()`](https://github.com/openjdk/jdk/blob/5c552a9d64c8116161cb9ef4c777e75a2602a75b/src/hotspot/share/opto/generateOptoStub.cpp#L267) and [`Compile::return_values()`](https://github.com/openjdk/jdk/blob/5c552a9d64c8116161cb9ef4c777e75a2602a75b/src/hotspot/share/opto/parse1.cpp#L879).
> 
> Tests: tiers 1 through 3 passed.

This pull request has now been integrated.

Changeset: 1fe45265
Author:    Manuel Hässig <manuel.hassig at oracle.com>
Committer: Tobias Hartmann <thartmann at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/1fe45265e446eeca5dc496085928ce20863a3172
Stats:     1 line in 1 file changed: 0 ins; 0 del; 1 mod

8350194: Last 2 parameters of ReturnNode::ReturnNode are swapped in the declaration

Reviewed-by: thartmann, epeter

-------------

PR: https://git.openjdk.org/jdk/pull/23927


More information about the hotspot-compiler-dev mailing list