RFR: 8350485: C2: factor out common code in Node::grow() and Node::out_grow() [v3]

Roberto Castañeda Lozano rcastanedalo at openjdk.org
Wed Mar 12 14:17:55 UTC 2025


On Wed, 12 Mar 2025 10:07:38 GMT, Saranya Natarajan <duke at openjdk.org> wrote:

>> Node:grow() and Node::out_grow() are copy-pasted from each other and their core logic could be factored out into a third function or at least cleaned up. Hence,the fix includes a function Node::array_resize() that implements the core logic of Node::grow() and Node::out_grow(). 
>> 
>>  Link to Github action which had no failures :  https://github.com/sarannat/jdk/actions/runs/13677508359
>
> Saranya Natarajan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8350485: Addressing review comments with code formatting and fixing/removing comments

Looks good, thanks!

-------------

Marked as reviewed by rcastanedalo (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/23928#pullrequestreview-2678681812


More information about the hotspot-compiler-dev mailing list