RFR: 8350835: C2 SuperWord: assert/wrong result when using Float.float16ToFloat with byte instead of short input [v2]

Sandhya Viswanathan sviswanathan at openjdk.org
Wed Mar 12 14:18:57 UTC 2025


On Wed, 12 Mar 2025 03:37:23 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> Sandhya Viswanathan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review comments
>
> test/hotspot/jtreg/compiler/vectorization/TestFloat16ToFloatConv.java line 78:
> 
>> 76:     @IR(counts = {IRNode.VECTOR_CAST_HF2F, "> 0"},
>> 77:         applyIfOr = {"UseCompactObjectHeaders", "false", "AlignVector", "false"},
>> 78:         applyIfPlatformOr = {"x64", "true", "aarch64", "true", "riscv64", "true"},
> 
> Can you kindly justify the need for compressed object header usage,  it will mainly impact the pre-loop trip count compuation. AlignVector should be sufficient since it's a whitelisted option

This check is taken from compiler/vectorization/TestFloatConversionsVector.java which also has float16 conversion tests to be in sync.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23939#discussion_r1991601610


More information about the hotspot-compiler-dev mailing list