RFR: 8330469: C2: Remove or change "PrintOpto && VerifyLoopOptimizations" as printing code condition [v3]
Christian Hagedorn
chagedorn at openjdk.org
Wed Mar 12 14:25:59 UTC 2025
On Wed, 12 Mar 2025 12:44:19 GMT, Saranya Natarajan <duke at openjdk.org> wrote:
>> src/hotspot/share/opto/split_if.cpp line 143:
>>
>>> 141: tty->print("Cloning up: ");
>>> 142: n->dump();
>>> 143: }
>>
>> Same here with this print and the other places in `clone_cmp_down()`: I think it's too verbose for `TraceLoopOpts`.
>>
>> Since Split-If is quite complex, I think it would make sense to add a "TraceSplitIf" flag to get more information about the optimization. It's probably out of scope of this bug, so we could do that in a separate RFE. For this PR, I suggest to just drop these printings and link this PR to the "TraceSplitIf" RFE in order to restore/update/improve these.
>
> Thank you for the review. I have created RFE [JDK-8351847](https://bugs.openjdk.org/browse/JDK-8351847) for the "TraceSplitIf"
Awesome, thanks a lot!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23959#discussion_r1991617296
More information about the hotspot-compiler-dev
mailing list