RFR: 8349582: APX NDD code generation for OpenJDK [v4]

Srinivas Vamsi Parasa sparasa at openjdk.org
Wed Mar 12 17:58:07 UTC 2025


On Thu, 6 Mar 2025 01:04:32 GMT, Sandhya Viswanathan <sviswanathan at openjdk.org> wrote:

>> Srinivas Vamsi Parasa has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   add flag(PD::...) and clean up loadNKlassCompactHeaders
>
> src/hotspot/cpu/x86/x86_64.ad line 9744:
> 
>> 9742: instruct rorI_immI8_legacy(rRegI dst, immI8 shift, rFlagsReg cr)
>> 9743: %{
>> 9744:   predicate(!UseAPX && !VM_Version::supports_bmi2() && n->bottom_type()->basic_type() == T_INT);
> 
> Don't need to change anything for non bmi2 platforms. The original predicate can be kept as is. This applies to all rorI, rolI, rorL, rolL.

Please see the updated code removing rorI, rolI, rorL, rolL for non bmi2 platforms.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23501#discussion_r1992022343


More information about the hotspot-compiler-dev mailing list