Integrated: 8351861: RISC-V: add simple assert at arrays_equals_v
Hamlin Li
mli at openjdk.org
Thu Mar 13 08:17:06 UTC 2025
On Wed, 12 Mar 2025 14:48:24 GMT, Hamlin Li <mli at openjdk.org> wrote:
> Hi,
> Can you help to review this trivial patch?
>
> `arrays_equals_v` and `arrays_equals` are 2 versions of the same node `AryEqNode`, input `elem_size` should be the same, so should share the same assert of `elem_size`, this also make the code below more clear.
> Although at the same time, we could do the similar thing like https://github.com/openjdk/jdk/pull/24006, but as the code of `arrays_equals_v` and `arrays_equals` seems not require the input must be a byte[] (although in the java level a string's payload is indeed a byte[]), so I'll just leave if as is.
>
> Thanks
This pull request has now been integrated.
Changeset: 6241d096
Author: Hamlin Li <mli at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/6241d09657fdd2bbd4f02cf6361df8bd07216147
Stats: 3 lines in 1 file changed: 3 ins; 0 del; 0 mod
8351861: RISC-V: add simple assert at arrays_equals_v
Reviewed-by: fyang
-------------
PR: https://git.openjdk.org/jdk/pull/24008
More information about the hotspot-compiler-dev
mailing list