Integrated: 8351839: RISC-V: Fix base offset calculation introduced in JDK-8347489
Fei Yang
fyang at openjdk.org
Thu Mar 13 12:08:58 UTC 2025
On Wed, 12 Mar 2025 11:24:23 GMT, Fei Yang <fyang at openjdk.org> wrote:
> As discussed in https://github.com/openjdk/jdk/pull/23633#discussion_r1974591975, there is no need to distinuish `T_BYTE` and `T_CHAR` when calculating base offset for strings.
> The reason is that the low-level character storage used for both Latin1 and UTF16 strings is always a byte array [1].
> So we should always use `T_BYTE` for both cases. This won't make a difference on the calculated base offset for now.
> But it's better to fix this for code readability purposes. Sanity tested on linux-riscv64 w/wo COH.
>
> [1] https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/java/lang/String.java#L160
This pull request has now been integrated.
Changeset: 375722f4
Author: Fei Yang <fyang at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/375722f4ab62865c45d8d76f01dc9c7209be57c8
Stats: 14 lines in 2 files changed: 0 ins; 6 del; 8 mod
8351839: RISC-V: Fix base offset calculation introduced in JDK-8347489
Reviewed-by: mli, fjiang
-------------
PR: https://git.openjdk.org/jdk/pull/24006
More information about the hotspot-compiler-dev
mailing list