RFR: 8350988: Consolidate Identity of self-inverse operations [v2]

[Hannes Greule]

On Wed, 12 Mar 2025 12:34:36 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Hannes Greule has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>> 
>>  - use Generators
>>  - after merge cleanup
>>  - Merge branch 'master' into involution-nodes
>>  - collapse impl, add more fitting nodes
>>  - test
>
> test/hotspot/jtreg/compiler/c2/irTests/InvolutionIdentityTests.java line 83:
> 
>> 81:         assertResultF(nanf);
>> 82: 
>> 83:         double ad = RunInfo.getRandom().nextDouble();
> 
> This actually only generates values between `0.0...1.0`.
> 
> Can you instead use `Generators.java`? It will make sure to generate "interesting" values, including different encodings of `NaN`, infinity, etc.

Good catch, I'm using Generators now. I'm currently not testing ReverseBytesS/US, but there also isn't support for short/char in Generators. Should I still add tests?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23851#discussion_r1993500894