RFR: 8316694: Implement relocation of nmethod within CodeCache
Evgeny Astigeevich
eastigeevich at openjdk.org
Thu Mar 13 13:57:08 UTC 2025
On Tue, 11 Feb 2025 22:05:13 GMT, Chad Rakoczy <duke at openjdk.org> wrote:
> This PR introduces a new function to replace nmethods, addressing [JDK-8316694](https://bugs.openjdk.org/browse/JDK-8316694). It enables the creation of new nmethods from existing ones, allowing method relocation in the code heap and supporting [JDK-8328186](https://bugs.openjdk.org/browse/JDK-8328186).
>
> When an nmethod is replaced, a deep copy is performed. The corresponding Java method is updated to reference the new nmethod, while the old one is marked as unused. The garbage collector handles final cleanup and deallocation.
>
> This change does not modify existing code paths and therefore does not benefit much from existing tests. New tests were created and confirmed to pass on x64/aarch64 for slowdebug/fastdebug/release.
src/hotspot/share/oops/method.hpp line 376:
> 374:
> 375: public:
> 376: static void set_code(const methodHandle& mh, nmethod* code, bool isRelocation);
I see you have added `isRelocation` to pass the assert. We don't need it because we don't have plans to relocate compiled-to-native wrappers at the moment. We only support relocation of compiled code.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23573#discussion_r1993577593
More information about the hotspot-compiler-dev
mailing list