RFR: 8316694: Implement relocation of nmethod within CodeCache

Evgeny Astigeevich eastigeevich at openjdk.org
Thu Mar 13 21:46:58 UTC 2025


On Tue, 11 Feb 2025 22:05:13 GMT, Chad Rakoczy <duke at openjdk.org> wrote:

> This PR introduces a new function to replace nmethods, addressing [JDK-8316694](https://bugs.openjdk.org/browse/JDK-8316694). It enables the creation of new nmethods from existing ones, allowing method relocation in the code heap and supporting [JDK-8328186](https://bugs.openjdk.org/browse/JDK-8328186).
> 
> When an nmethod is replaced, a deep copy is performed. The corresponding Java method is updated to reference the new nmethod, while the old one is marked as unused. The garbage collector handles final cleanup and deallocation.
> 
> This change does not modify existing code paths and therefore does not benefit much from existing tests. New tests were created and confirmed to pass on x64/aarch64 for slowdebug/fastdebug/release.

test/hotspot/jtreg/compiler/whitebox/RelocateAllNMethods.java line 98:

> 96: import jdk.test.whitebox.WhiteBox;
> 97: 
> 98: public class RelocateAllNMethods {

Relocate all without destination looks confusing. You need to specify where to relocate nmethods. Also there would be not many compiled code. It mostly tests relocation of code which cannot be relocated.
IMO it's better to compile a bunch of method, to relocate them, and to execute them.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23573#discussion_r1994342904


More information about the hotspot-compiler-dev mailing list