RFR: 8316694: Implement relocation of nmethod within CodeCache [v3]

Vladimir Kozlov kvn at openjdk.org
Sat Mar 15 00:58:00 UTC 2025


On Fri, 14 Mar 2025 22:03:44 GMT, Dean Long <dlong at openjdk.org> wrote:

>> Chad Rakoczy has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Share immutable data between copied nmethods
>
> src/hotspot/share/code/nmethod.hpp line 587:
> 
>> 585:   address immutable_data_references_begin      () const { return           _immutable_data + _immutable_data_references_offset   ; }
>> 586:   address immutable_data_references_end        () const { return            immutable_data_end(); }
>> 587: 
> 
> If we are going to add typed fields to this data, maybe we should put it in a struct/class header at the beginning so we can access the field directly?

I am not sure adding one integers field justifies new structure. It is better to keep this counter at the end of this block since it is accessed only few times.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23573#discussion_r1996464592


More information about the hotspot-compiler-dev mailing list