RFR: 8352110: [ASAN] heap-use-after-free of task->directive()->PrintCompilationOption [v2]
Christian Hagedorn
chagedorn at openjdk.org
Mon Mar 17 06:51:59 UTC 2025
On Mon, 17 Mar 2025 06:08:50 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:
>> SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Set PrintCompilation to true when receive CompileCommandEnum::PrintCompilation
>
> src/hotspot/share/compiler/compilerOracle.cpp line 338:
>
>> 336:
>> 337: if (option == CompileCommandEnum::PrintCompilation) {
>> 338: PrintCompilation = true;
>
> But this will set `PrintCompilation` to true globally, right? The directive should only apply to a specific method.
Yes, we only want to have it enabled for certain methods. Let's do a backout of JDK-8351938 instead to address the problems properly in a REDO.
https://github.com/openjdk/jdk/pull/24074
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24073#discussion_r1998045288
More information about the hotspot-compiler-dev
mailing list