RFR: 8316694: Implement relocation of nmethod within CodeCache [v4]

Evgeny Astigeevich eastigeevich at openjdk.org
Mon Mar 17 13:12:55 UTC 2025


On Fri, 14 Mar 2025 21:57:21 GMT, Chad Rakoczy <duke at openjdk.org> wrote:

>> This PR introduces a new function to replace nmethods, addressing [JDK-8316694](https://bugs.openjdk.org/browse/JDK-8316694). It enables the creation of new nmethods from existing ones, allowing method relocation in the code heap and supporting [JDK-8328186](https://bugs.openjdk.org/browse/JDK-8328186).
>> 
>> When an nmethod is replaced, a deep copy is performed. The corresponding Java method is updated to reference the new nmethod, while the old one is marked as unused. The garbage collector handles final cleanup and deallocation.
>> 
>> This change does not modify existing code paths and therefore does not benefit much from existing tests. New tests were created and confirmed to pass on x64/aarch64 for slowdebug/fastdebug/release.
>
> Chad Rakoczy has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix build issues

src/hotspot/share/code/nmethod.cpp line 1471:

> 1469:     // Clear inline caches before acquiring any locks
> 1470:     VM_ClearNMethodICs clear_nmethod_ics(nm);
> 1471:     VMThread::execute(&clear_nmethod_ics);

This does not look correct.
Why are you doing this?
What are you trying to fix?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23573#discussion_r1998700403


More information about the hotspot-compiler-dev mailing list